A man with a mission...

sdwilsh Status Update: 2011-08-13

Done:

  • Reviewed bug 598794 - Intermittent failure in uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 0), see following log: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]
  • Reviewed bug 665549 - Fix unused variable warning for 'shutdownObserved' in mozStorageService.cpp
  • Reviewed bug 665328 - Remove the unused Storage string
  • Reviewed bug 665219 - Helper App Service should accept a filename hint on a channel
  • Reviewed bug 658368 - Expand console object with time and timeEnd methods
  • Reviewed bug 662989 - Avoid crashing if a DB connection isn't asyncClose()d when it should be
  • Reviewed bug 655658 - NetUtil.readInputStreamToString should have aCharset argument as optional
  • Reviewed bug 665580 - Hide http:// and single trailing slashes in the location bar
  • Reviewed bug 668906 - NULL dereference in openUnsharedDatabase with functiontimer
  • Reviewed bug 663612 - clicking a group should zoom into the group's active tab
  • Reviewed bug 591289 - Save chosen download file name and other metadata in Places history

sdwilsh Status Update: 2011-06-03

Done:

  • Reviewed bug 660532 - Useless uses of PromiseFlatCString
  • Reviewed bug 659740 - Frecency update causes SQL sort warning
  • Reviewed bug 659625 - Expand console object with clear method
  • Reviewed bug 649088 - Use default favicon consistent with rest of browser
  • Reviewed bug 661135 - Minor performance improvements to autocomplete queries
  • Reviewed bug 661091 - iQ.animate: only animate properties that are changing
  • Reviewed bug 660743 - storage should use mozilla::Preferences
  • Reviewed bug 658368 - Expand console object with time and timeEnd methods
  • Reviewed bug 660592 - Allow autocomplete results to hide themselves from the popup
  • Released version 0.3.0 of the node.js library for Pulse. Now with good documentation and it's tested!

sdwilsh Status Update: 2011-05-27

Done:

  • Reviewed bug 655776 - Web Developer > Get More Tools menu item
  • Reviewed bug 566489 - Enable inline autocomplete again, but make it smarter (perceived performance)
  • Reviewed bug 658135 - Use sqlite3_stmt_readonly to check if multiple async statements need a transaction
  • Reviewed bug 564934 - Implement new Download Manager UI for browser
  • Reviewed bug 647886 - Pulling down Back/Forward menu requires an unnecessary delay
  • Reviewed bug 657961 - Use async API to get favicons for site permissions page
  • Reviewed bug 659693 - domain highlighting doesn't work with IPv6 literals
  • Reviewed bug 659332 - trailing // should disappear if input text is something like "filxxxx" in the LocationBar
  • Wrote a library to connect to pulse for node.js
  • Started work on tree-bot, a helpful bot to tell you when you've broken the tree or have test failures.

sdwilsh Status Update: 2011-05-20

Done:

  • Reviewed bug 633274 - nsINavBookmarkObserver: also pass in GUID whenever we pass in an item id
  • Reviewed bug 656188 - Cache last 10 fetched bookmarks info to speed up repeated requests
  • Reviewed bug 598833 - Consider storing intrinsic state in a direct member of Element
  • Reviewed bug 566489 - Enable inline autocomplete again, but make it smarter (perceived performance)
  • Reviewed bug 656545 - Make about:memory tool-tips more discoverable
  • Reviewed bug 657327 - about:memory merge the "mapped" and "heap used" trees, and make the resulting tree flatter
  • Provided feedback on bug 655270 - SHEntries created by pushState don't have favicon
  • Reviewed bug 649867 - Fix or remove the heap-used/storage/lookaside-used memory reporter
  • Reviewed bug 573176 - Implement Site-Specific Privacy Preferences
  • Reviewed bug 566489 - Enable inline autocomplete again, but make it smarter (perceived performance)
  • Reviewed bug 658135 - Use sqlite3_stmt_readonly to check if multiple async statements need a transaction
  • Reviewed bug 650573 - Panorama hangs when restoring a session
  • Reviewed bug 658344 - Create some useful introductory text for the Scratchpad
  • Reviewed bug 658135 - Use sqlite3_stmt_readonly to check if multiple async statements need a transaction
  • Reviewed bug 657131 - Create a new Execute menu for Scratchpad
  • Blogged about what I look for during a review
  • Reviewed bug 656773 - about:memory error in private browsing mode, page is blank
  • Reviewed bug 653108 - Scratchpad is tied to the tab it was first run in
  • Continued to investigate a tp4 chrome performance regression. Finally getting some interesting data.

Coordination:

I am changing jobs on June 1st, so my review queue bandwidth is going to decrease, which will likely result in slightly longer wait times. I hope to keep it limited to three business days after June 1st, however.

sdwilsh Status Update: 2011-05-13

Done:

  • Reviewed bug 654732 - Remove WinCE code from storage/* & db/sqlite3/src/Makefile.in
  • Reviewed bug 653630 - Negative value for "heap-used/other" in about:memory due to sqlite reporters double-counting some memory
  • Reviewed bug 650509 - Other apps can read Firefox profile files
  • Reviewed bug 493783 - Fixing warnings in toolkit components (places and commandline)
  • Cleaned up bug 584316 (Fix DownloadManager usage of deprecated Storage binding APIs) so it can land.
  • Reviewed bug 633274 - nsINavBookmarkObserver: also pass in GUID whenever we pass in an item id
  • Pushed lots of stuff to the try server and triggered a bunch of extra talos runs to start establishing a regression range for bug 655930 - Windows chrome seems to be a 25% pageload hit
  • Reviewed bug 577721 - allow repositioning of the web console: above, below and out into a panel/window
  • Provided feedback on bug 573176 - Implement Site-Specific Privacy Preferences

Coordination:

My review/feedback queue has gotten a number of large patches in it lately, which has resulted in some longer waiting times for reviews. Small patches are still getting fast turn around, but the bigger ones have a bit of a waiting period.

« Previous PageNext Page »