Comments on: Test Build: Asynchronous Location Bar Searches

By: Test Add-on: Asynchronous Location Bar Searches (Take 3) : Shawn Wilsher

Test Add-on: Asynchronous Location Bar Searches (Take 3) : Shawn Wilsher — Mon, 23 Feb 2009 04:41:19 +0000

[...] Bar Searches (Take 2)Test Build: Asynchronous Location Bar Searches (Take 2) : Shawn Wilsher on Test Build: Asynchronous Location Bar SearchesShawn Wilsher on Test Build: Asynchronous Location Bar SearchesCesar on Test Build: Asynchronous [...]

By: Test Build: Asynchronous Location Bar Searches (Take 2) : Shawn Wilsher

Test Build: Asynchronous Location Bar Searches (Take 2) : Shawn Wilsher — Sun, 22 Feb 2009 06:01:18 +0000

[...] Comments Shawn Wilsher on Test Build: Asynchronous Location Bar SearchesCesar on Test Build: Asynchronous Location Bar SearchesBen Hearsum on Test Build: Asynchronous [...]

By: Shawn Wilsher

Shawn Wilsher — Sat, 21 Feb 2009 00:45:18 +0000

@Cesar You'd be looking for bug 455555

By: Cesar

Cesar — Sat, 21 Feb 2009 00:08:39 +0000

This sounds awesome. I try to keep as much history as possible, so searches can take a while under certain circumstances. Do you have a bug # where the patch is located? The try-server doesn’t seem to do both linux x86 and x86-64, and I’m the minority latter.

By: Ben Hearsum

Ben Hearsum — Fri, 20 Feb 2009 20:38:57 +0000

Awesome. I’ll give it a try.

By: Shawn Wilsher

Shawn Wilsher — Fri, 20 Feb 2009 18:45:31 +0000

@Ben
That’s what we are trying to solve! I’m not so sure this patch is enough mind you, but it’s a step in the right direction.

By: Ben Hearsum

Ben Hearsum — Fri, 20 Feb 2009 18:39:37 +0000

Does this mean that searching in the awesomebar won’t hang the UI?

By: Shawn Wilsher

Shawn Wilsher — Fri, 20 Feb 2009 05:28:49 +0000

@Edward
Yes, with some minor adjustments.

By: Edward Lee

Edward Lee — Fri, 20 Feb 2009 05:25:31 +0000

I suppose another thing to mention is that the original C++ code was rewritten as this async implementation in javascript.